Graph Equivalence Changes #491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
emmanvg
commented
Feb 16, 2021
emmanvg
commented
- fix in algorithm to guarantee symmetry
- add different functions for "similarity" and "equivalence"
busted main loop, symmetrical properties not present
- new methods for graph equivalence and similarity - remove sorting and len comparisons - rename some variables
Codecov Report
@@ Coverage Diff @@
## master #491 +/- ##
==========================================
- Coverage 89.27% 89.27% -0.01%
==========================================
Files 146 147 +1
Lines 16032 16442 +410
==========================================
+ Hits 14313 14678 +365
- Misses 1719 1764 +45
Continue to review full report at Codecov.
|
…ve redundant object_similarity call update test suite
clenk
reviewed
Feb 18, 2021
Co-authored-by: Chris Lenk <[email protected]>
update variable names Co-authored-by: Chris Lenk <[email protected]>
Co-authored-by: Chris Lenk <[email protected]>
docstrings Co-authored-by: Chris Lenk <[email protected]>
docstrings Co-authored-by: Chris Lenk <[email protected]>
docstrings Co-authored-by: Chris Lenk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.