Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ordering problem with Class definitions #474

Merged
merged 3 commits into from
Nov 20, 2020

Conversation

emmanvg
Copy link
Contributor

@emmanvg emmanvg commented Nov 19, 2020

closes #472

@emmanvg emmanvg added this to the 2.1.0 milestone Nov 19, 2020
@emmanvg emmanvg requested a review from clenk November 19, 2020 00:02
@codecov-io
Copy link

codecov-io commented Nov 19, 2020

Codecov Report

Merging #474 (e7242c9) into master (3cef32e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #474   +/-   ##
=======================================
  Coverage   89.33%   89.33%           
=======================================
  Files         144      144           
  Lines       16020    16020           
=======================================
  Hits        14311    14311           
  Misses       1709     1709           
Impacted Files Coverage Δ
stix2/test/v21/test_malware_analysis.py 100.00% <ø> (ø)
stix2/v20/common.py 49.33% <ø> (ø)
stix2/v21/common.py 44.28% <ø> (ø)
stix2/v21/observables.py 34.69% <ø> (ø)
stix2/v21/sdo.py 59.44% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3cef32e...e7242c9. Read the comment docs.

Copy link
Contributor

@clenk clenk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After looking through the examples in the spec, this looks like this lines up with the ordering used in those examples. 👍

@clenk clenk merged commit f9e9c50 into oasis-open:master Nov 20, 2020
@emmanvg emmanvg deleted the 472-issue branch November 20, 2020 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

STIX Objects: Property ordering
3 participants