-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Graph Equivalence #449
Graph Equivalence #449
Conversation
Codecov Report
@@ Coverage Diff @@
## master #449 +/- ##
==========================================
+ Coverage 98.24% 98.26% +0.02%
==========================================
Files 142 144 +2
Lines 15748 15996 +248
==========================================
+ Hits 15471 15718 +247
- Misses 277 278 +1
Continue to review full report at Codecov.
|
82adcdc
to
ddccc6f
Compare
…e.object_equivalence.rst for docs
…c_check not keeping highest score
ddccc6f
to
2d9752e
Compare
doctrings update
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good!
Can we make the names of the semantic equivalence submodules consistent? Right now we have graph_equivalence
, object_equivalence
, and patterns
. Since they're already under equivalence
it's redundant to include it at this level too I think.
- rename semantic_check to reference_check - rename modules to graph and object respectively to eliminate redundancy - remove created_by_ref and object_marking_refs from graph WEIGHTS and rebalance
…ad of the full list, only create entry when type is present in WEIGHTS dictionary update tests to reflect changes
4975f8a
to
339d744
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @emmanvg!
This PR provides the ability for a user to perform equivalence checks for two graphs.
environment.py
to prevent breaking changestix2.environment.Environment.graphically_equivalent()
but also viastix2.equivalence.graph_equivalence.graphically_equivalent()