Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SELECTOR_REGEX for GranularMarkings #407

Merged
merged 1 commit into from
Jun 8, 2020

Conversation

emmanvg
Copy link
Contributor

@emmanvg emmanvg commented Jun 8, 2020

Fixes #406

@emmanvg emmanvg added this to the 2.0.0 milestone Jun 8, 2020
@codecov-commenter
Copy link

Codecov Report

Merging #407 into master will decrease coverage by 0.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #407      +/-   ##
==========================================
- Coverage   98.43%   98.31%   -0.12%     
==========================================
  Files         127      128       +1     
  Lines       14652    14394     -258     
==========================================
- Hits        14423    14152     -271     
- Misses        229      242      +13     
Impacted Files Coverage Δ
stix2/properties.py 97.89% <100.00%> (-0.53%) ⬇️
stix2/test/v20/test_granular_markings.py 100.00% <100.00%> (ø)
stix2/test/v21/test_granular_markings.py 100.00% <100.00%> (ø)
stix2/canonicalization/Canonicalize.py 59.03% <0.00%> (-2.01%) ⬇️
stix2/base.py 96.75% <0.00%> (-1.15%) ⬇️
stix2/utils.py 96.27% <0.00%> (-0.94%) ⬇️
stix2/test/v21/test_parsing.py 89.65% <0.00%> (-0.67%) ⬇️
stix2/datastore/filesystem.py 94.21% <0.00%> (-0.10%) ⬇️
stix2/test/v20/test_datastore_filesystem.py 99.19% <0.00%> (-0.02%) ⬇️
... and 67 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41525f9...aa18575. Read the comment docs.

Copy link
Contributor

@clenk clenk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @emmanvg!

@clenk clenk merged commit 8bde22f into oasis-open:master Jun 8, 2020
@emmanvg emmanvg deleted the flexibility-selector-syntax branch June 8, 2020 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Placing GranularMarking on id property causes ValueError
3 participants