-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support STIX 2.1 version precision #374
Conversation
on versioning timestamps.
pre-commit hook doesn't add all the commas Travis's hook script expects...
There is a test failure specific to Python 3.6. I think it might be a result of: https://bugs.python.org/issue32404 My unit test uses |
Codecov Report
@@ Coverage Diff @@
## master #374 +/- ##
==========================================
+ Coverage 98.18% 98.19% +0.01%
==========================================
Files 124 125 +1
Lines 14238 14333 +95
==========================================
+ Hits 13980 14075 +95
Misses 258 258
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM; thanks @chisholm!
Fixes #350 , #329
The new rules say versioning timestamps need at least millisecond precision; the old ones said exactly millisecond precision. So we are able to allow more precision in those timestamps now. This PR adds support for expressing and enforcing a minimum precision on versioning timestamps.