Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update malware-analysis SDO's av_result property #357

Merged
merged 1 commit into from
Mar 11, 2020

Conversation

chisholm
Copy link
Contributor

From oasis-tcs/cti-stix2#213
Fixes half of #339 .

Replace the av_result property with result and result_name properties.

@codecov-io
Copy link

Codecov Report

Merging #357 into master will decrease coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #357      +/-   ##
=========================================
- Coverage   98.15%   98.1%   -0.05%     
=========================================
  Files         124     124              
  Lines       14176   13859     -317     
=========================================
- Hits        13914   13597     -317     
  Misses        262     262
Impacted Files Coverage Δ
stix2/test/v21/test_malware_analysis.py 100% <ø> (ø) ⬆️
stix2/v21/sdo.py 94.53% <100%> (ø) ⬆️
stix2/datastore/filesystem.py 92.88% <0%> (-0.12%) ⬇️
stix2/patterns.py 98% <0%> (-0.02%) ⬇️
stix2/test/v21/test_datastore_filesystem.py 99.17% <0%> (-0.02%) ⬇️
stix2/test/v20/test_datastore_filesystem.py 99.19% <0%> (-0.02%) ⬇️
stix2/test/v21/test_relationship.py 100% <0%> (ø) ⬆️
stix2/test/v20/test_campaign.py 100% <0%> (ø) ⬆️
stix2/test/v21/test_core.py 100% <0%> (ø) ⬆️
stix2/test/v21/test_attack_pattern.py 100% <0%> (ø) ⬆️
... and 59 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2b7167...d2bff4d. Read the comment docs.

@emmanvg emmanvg added this to the 1.4.0 milestone Mar 3, 2020
Copy link
Contributor

@clenk clenk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@clenk clenk merged commit 33fb314 into oasis-open:master Mar 11, 2020
@chisholm chisholm deleted the malware_analysis_result branch March 11, 2020 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants