Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the "sample_ref" property to malware-analysis SDOs #356

Merged
merged 1 commit into from
Mar 11, 2020
Merged

Add the "sample_ref" property to malware-analysis SDOs #356

merged 1 commit into from
Mar 11, 2020

Conversation

chisholm
Copy link
Contributor

From oasis-tcs/cti-stix2#210
Fixes half of #339 .

@codecov-io
Copy link

codecov-io commented Feb 27, 2020 •
edited
Loading

Codecov Report

Merging #356 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #356   +/-   ##
=======================================
  Coverage   98.15%   98.15%           
=======================================
  Files         124      124           
  Lines       14176    14176           
=======================================
  Hits        13914    13914           
  Misses        262      262
Impacted Files Coverage Δ
stix2/v21/sdo.py 94.53% <ø> (ø) ⬆️
stix2/test/v21/test_malware_analysis.py 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2b7167...50eb188. Read the comment docs.

@emmanvg emmanvg added this to the 1.4.0 milestone Mar 3, 2020
clenk
clenk approved these changes Mar 11, 2020
View reviewed changes
Copy link
Contributor

@clenk clenk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@clenk clenk merged commit bdf7cab into oasis-open:master Mar 11, 2020
@clenk clenk mentioned this pull request Mar 11, 2020
Closed
@chisholm chisholm deleted the malware_analysis_sample_ref branch March 11, 2020 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clenk clenk clenk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.
4 participants
@chisholm @codecov-io @clenk @emmanvg