Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #336 #346

Merged
merged 2 commits into from
Feb 21, 2020
Merged

Fixes #336 #346

merged 2 commits into from
Feb 21, 2020

Conversation

khdesai
Copy link
Contributor

@khdesai khdesai commented Feb 19, 2020

No description provided.

@codecov-io
Copy link

codecov-io commented Feb 19, 2020

Codecov Report

Merging #346 into master will increase coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #346      +/-   ##
==========================================
+ Coverage    98.1%   98.17%   +0.06%     
==========================================
  Files         124      124              
  Lines       14185    14159      -26     
==========================================
- Hits        13916    13900      -16     
+ Misses        269      259      -10
Impacted Files Coverage Δ
stix2/test/v21/test_observed_data.py 100% <ø> (ø) ⬆️
stix2/v21/observables.py 96.93% <100%> (-0.21%) ⬇️
stix2/properties.py 98.36% <0%> (+0.54%) ⬆️
stix2/utils.py 97.72% <0%> (+1.13%) ⬆️
stix2/base.py 98.85% <0%> (+1.14%) ⬆️
stix2/canonicalization/Canonicalize.py 61.44% <0%> (+1.2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8aca39a...8219b34. Read the comment docs.

Copy link
Contributor

@clenk clenk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@clenk clenk merged commit 148d672 into oasis-open:master Feb 21, 2020
@emmanvg emmanvg added this to the 1.3.1 milestone Feb 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants