Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 308 #315

Merged
merged 2 commits into from
Dec 17, 2019
Merged

Fix issue 308 #315

merged 2 commits into from
Dec 17, 2019

Conversation

khdesai
Copy link
Contributor

@khdesai khdesai commented Dec 17, 2019

No description provided.

@codecov-io
Copy link

codecov-io commented Dec 17, 2019

Codecov Report

Merging #315 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #315      +/-   ##
==========================================
+ Coverage   98.15%   98.15%   +<.01%     
==========================================
  Files         123      123              
  Lines       13894    13913      +19     
==========================================
+ Hits        13638    13657      +19     
  Misses        256      256
Impacted Files Coverage Δ
stix2/v21/sdo.py 95.4% <ø> (ø) ⬆️
stix2/test/v21/test_indicator.py 100% <100%> (ø) ⬆️
stix2/v20/bundle.py 100% <100%> (ø) ⬆️
stix2/v21/bundle.py 100% <100%> (ø) ⬆️
stix2/v20/sdo.py 100% <100%> (ø) ⬆️
stix2/properties.py 98.4% <100%> (+0.01%) ⬆️
stix2/base.py 98.84% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 387810c...6df7da6. Read the comment docs.

Copy link
Contributor

@clenk clenk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks @khdesai!

@clenk clenk merged commit cde57ce into oasis-open:master Dec 17, 2019
@emmanvg emmanvg added this to the 1.3.0 milestone Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants