Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove at_least_one=False from Artifact SCO #290

Merged
merged 2 commits into from
Sep 19, 2019
Merged

Remove at_least_one=False from Artifact SCO #290

merged 2 commits into from
Sep 19, 2019

Conversation

khdesai
Copy link
Contributor

@khdesai khdesai commented Sep 18, 2019

No description provided.

@codecov-io
Copy link

codecov-io commented Sep 18, 2019

Codecov Report

Merging #290 into stix2.1 will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           stix2.1     #290   +/-   ##
========================================
  Coverage    98.09%   98.09%           
========================================
  Files          123      123           
  Lines        13409    13409           
========================================
  Hits         13154    13154           
  Misses         255      255
Impacted Files Coverage Δ
stix2/v21/observables.py 96.96% <100%> (ø) ⬆️
stix2/base.py 98.84% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1a88a4...113d481. Read the comment docs.

Copy link
Contributor

@clenk clenk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@clenk clenk merged commit c3b2121 into oasis-open:stix2.1 Sep 19, 2019
@emmanvg emmanvg added this to the 1.2.0 milestone Sep 23, 2019
@khdesai khdesai deleted the wd05SCO branch October 7, 2019 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants