WD 05 SCO

[khdesai]

No description provided.

[rpiazza]

Is there a reason why the process observable's ID is specified as:

    ('id', IDProperty(_type)),

instead of

    ('id', IDProperty(_type, spec_version='2.1')),

[khdesai]

Is there a reason why the process observable's ID is specified as:

    ('id', IDProperty(_type)),

instead of

    ('id', IDProperty(_type, spec_version='2.1')),

No reason, that's just a relic of an old way I used to separate the Process SCO from the other SCOs when it came time to creating a deterministic ID (since Process doesn't use deterministic IDs). I've added the spec_version back in. Thanks for catching that.

[clenk]

There are some common properties we need to add to all SCOs: spec_version, object_marking_refs, granular_markings, defanged.

EmailMessage is missing the message_id property.

Also, in 2.1 *_ref[s] properties now contain identifiers rather than object-refs. So for example instead of "resolves_to_refs": ["1"] it would be "resolves_to_refs": ["ipv4-addr--<uuid>"].

[codecov-io]

Codecov Report

Merging #285 into stix2.1 will decrease coverage by 0.91%.
The diff coverage is 76.79%.

@@             Coverage Diff             @@
##           stix2.1     #285      +/-   ##
===========================================
- Coverage    99.01%   98.09%   -0.92%     
===========================================
  Files          121      123       +2     
  Lines        12924    13409     +485     
===========================================
+ Hits         12797    13154     +357     
- Misses         127      255     +128

Impacted Files	Coverage Δ
stix2/test/v21/test_datastore_filters.py	100% <ø> (ø)	⬆️
stix2/v21/sdo.py	95.29% <ø> (ø)	⬆️
stix2/test/v21/test_utils.py	100% <ø> (ø)	⬆️
stix2/v21/common.py	100% <ø> (ø)	⬆️
stix2/v20/common.py	100% <ø> (ø)	⬆️
stix2/test/v21/test_core.py	100% <ø> (ø)	⬆️
stix2/v20/sdo.py	100% <ø> (ø)	⬆️
stix2/test/v20/test_utils.py	100% <ø> (ø)	⬆️
stix2/v21/observables.py	96.96% <100%> (+0.6%)	⬆️
stix2/test/v21/test_observed_data.py	100% <100%> (ø)	⬆️
... and 11 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2a649b...3b1c922. Read the comment docs.

[clenk]

Thanks @khdesai!