Update course of action for stix2.1 (again) #273
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that two property types were wrong, for
action_bin
andaction_reference
. The former was a string property, but should be binary. The latter was also a string property, but should be external-reference. I don't know if I just goofed when I created those properties originally, or if the spec changed right after I wrote them. Seems like I wouldn't have used string properties if they weren't string typed! Maybe the spec is just changing too fast...Also added tests for courses of action which have references (as opposed to binaries, via
action_bin
).After having had the experience of writing the malware-analysis tests, I decided to change these tests to be written in a similar style. It means a lot less tedious writing of long lists of keyword args and big dicts. So the tests are better now, with less code (I hope).