Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update course of action for stix2.1 (again) #273

Merged
merged 2 commits into from
Jun 28, 2019

Conversation

chisholm
Copy link
Contributor

I found that two property types were wrong, for action_bin and action_reference. The former was a string property, but should be binary. The latter was also a string property, but should be external-reference. I don't know if I just goofed when I created those properties originally, or if the spec changed right after I wrote them. Seems like I wouldn't have used string properties if they weren't string typed! Maybe the spec is just changing too fast...

Also added tests for courses of action which have references (as opposed to binaries, via action_bin).

After having had the experience of writing the malware-analysis tests, I decided to change these tests to be written in a similar style. It means a lot less tedious writing of long lists of keyword args and big dicts. So the tests are better now, with less code (I hope).

chisholm added 2 commits June 26, 2019 19:54
action_reference property.  Also, stylistic changes to hopefully
let it do more testing with less code.
@codecov-io
Copy link

Codecov Report

Merging #273 into stix2.1 will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           stix2.1     #273      +/-   ##
===========================================
- Coverage    98.64%   98.64%   -0.01%     
===========================================
  Files          119      119              
  Lines        12900    12896       -4     
===========================================
- Hits         12725    12721       -4     
  Misses         175      175
Impacted Files Coverage Δ
stix2/v21/sdo.py 93.79% <ø> (ø) ⬆️
stix2/test/v21/test_course_of_action.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8c5bec...e779cac. Read the comment docs.

@clenk clenk merged commit 953a91b into oasis-open:stix2.1 Jun 28, 2019
@chisholm chisholm deleted the update_course_of_action branch June 28, 2019 17:49
@emmanvg emmanvg added this to the 1.2.0 milestone Sep 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants