-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update dict key limits per 2.1 spec #198
Conversation
Codecov Report
@@ Coverage Diff @@
## stix2.1 #198 +/- ##
===========================================
- Coverage 97.06% 95.79% -1.28%
===========================================
Files 75 76 +1
Lines 7525 7745 +220
===========================================
+ Hits 7304 7419 +115
- Misses 221 326 +105
Continue to review full report at Codecov.
|
@treyka thanks for updating the properties and make |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is more stuff to be done, but we can address in a different PR.
Thanks, @treyka ! |
In the course of testing the i18n code in the 2.1 branch, I noticed that while the
language-content
contents
property allows 2 char dict keys for specifying languages (as shown in all of the examples and per RFC5646), the 2.1 branch still retained the 2.0 3 char restriction on dict key length.QED, I split properties.py out v20 vs v21 as was done previously to accommodate other 2.1 changes.
Also, somewhat inexplicably the STIX2 dictionary property limits key length to 250 (not 256). While I was mucking about, I fixed this on for 2.1.