Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Registering new custom Object and Observable does not check for duplicates #363

Closed
khdesai opened this issue Mar 6, 2020 · 0 comments
Closed

Registering new custom Object and Observable does not check for duplicates #363

khdesai opened this issue Mar 6, 2020 · 0 comments
Milestone
1.4.0

Comments

@khdesai
Copy link
Contributor

khdesai commented Mar 6, 2020

When registering a new custom object or observable, the _register_object and _register_observable functions do not check to see if the type of the object/observable being passed in already exists in OBJ_MAP, which could lead to an existing type being overwritten
khdesai added a commit to khdesai/cti-python-stix2 that referenced this issue Mar 20, 2020
@khdesai
Fixes oasis-open#363
1a1ad90
khdesai added a commit to khdesai/cti-python-stix2 that referenced this issue Mar 27, 2020
@khdesai
Add duplicate checking to markings and observable extensions, and fix…
c911cff 
… some tests and add some tests. Fixes oasis-open#363
@clenk clenk closed this as completed in 1260c7b Apr 2, 2020
clenk added a commit that referenced this issue Apr 2, 2020
@clenk
Merge pull request #376 from khdesai/fix_issue_363
bbf0f81 
Fix existing tests and add new tests. Fixes #363
@emmanvg emmanvg added this to the 1.4.0 milestone Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.4.0
Development

No branches or pull requests
2 participants
@emmanvg @khdesai