Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding pre-commit hook for add-trailing-comma #189

Closed
gtback opened this issue Jun 11, 2018 · 0 comments
Closed

Consider adding pre-commit hook for add-trailing-comma #189

gtback opened this issue Jun 11, 2018 · 0 comments
Assignees
Milestone

Comments

@gtback
Copy link
Contributor

gtback commented Jun 11, 2018

https://github.com/asottile/add-trailing-comma

In the default configuration, this seems to conflict with our isort configuration (they try to overwrite each other). This will take some work to resolve. We should probably wait until we merge in the STIX 2.1 branch, to avoid having to make the same changes in multiple places.

@gtback gtback added this to the STIX 2.1 milestone Jun 11, 2018
@emmanvg emmanvg self-assigned this Jul 13, 2018
@emmanvg emmanvg modified the milestones: 2.0.0, 1.1.0 Oct 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants