This repository has been archived by the owner on Nov 14, 2022. It is now read-only.
Change the variable name so that the passed parameters are correct #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting one pmem path on AppDirect mode may cause the pmem initialization path to be empty Path
winningsix
reviewed
Feb 2, 2021
| @@ -210,8 +210,8 @@ private[spark] class BlockManager( | |||
| } | |||
|
|
|||
| require(file.isDirectory(), "PMem directory is required for initialization") | |||
| PersistentMemoryPlatform.initialize(initPath, pmemInitialSize, 0) | |||
| logInfo(s"Intel Optane PMem initialized with path: ${initPath}, size: ${pmemInitialSize} ") | |||
| PersistentMemoryPlatform.initialize(path_postfix, pmemInitialSize, 0) | |||
There was a problem hiding this comment.
@winningsix Thanks for reminding, the absolute path of the object should be passed as a parameter
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)