Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML-41] Revert to old oneCCL and Prepare for OAP 1.1 #40

Merged
merged 15 commits into from
Mar 23, 2021
Merged

[ML-41] Revert to old oneCCL and Prepare for OAP 1.1 #40

merged 15 commits into from
Mar 23, 2021

Conversation

xwu99
Copy link
Collaborator

@xwu99 xwu99 commented Mar 19, 2021 •
edited
Loading

What changes were proposed in this pull request?

#41

  • Revert to old oneCCL (beta 08) for OAP 1.1
  • Use oneAPI SDK 2021.1.0 (l_BaseKit_p_2021.1.0.2659_offline.sh) for building
  • Support Kmeans and PCA, will not include ALS as we are fixing issues
  • Small fixes
  • README update

xwu99 added 11 commits March 19, 2021 15:19
@xwu99
Revert "[ML-33] Optimize oneCCL port detecting (oap-project#34)"
b6b6274 
This reverts commit c07d70c.
@xwu99
Revert "[ML-12] Improve CI and add pseudo cluster testing (oap-projec…
712dd42 
…t#20)"

This reverts commit 6fe5d3e.
@xwu99
Revert "Print time duration for each PCA step (oap-project#32)"
284fa69 
This reverts commit e1c33d9.
@xwu99
Revert "[ML-13] Add ALS with new oneCCL APIs (oap-project#14)"
e2185f8 
This reverts commit 3252ae9.
@xwu99
Revert "[ML-25] Fix oneCCL KVS port auto detect and improve logging (o…
f18efb6 
…ap-project#24)"

This reverts commit 9080d02.
@xwu99
Revert "[ML-18] Auto detect KVS port for oneCCL to avoid port conflict (
3853828 
oap-project#19)"

This reverts commit ac20823.
@xwu99
Revert "Merge pull request oap-project#11 from xwu99/new-oneccl"
b243416 
This reverts commit b60158b, reversing
changes made to db2414c.
@xwu99
Revert "use spark.oap.mllib.oneccl.kvs.ip to workaround KVS IP hang i…
6907308 
…ssue"

This reverts commit 318cae1.
@xwu99
Revert "Add IP Port kvs_attr and Kmeans, PCA test cases validated"
ad36086 
This reverts commit 99b9551.
@xwu99
Revert "Port oneccl to new C++ apis"
20b5fa8 
This reverts commit ac216f4.
@xwu99
Fix Makefile
8c0e82d 
Add build.sh
Fix oap-mllib-ci.yml
Fix OneCCL port for multiple test run
@github-actions
Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?
https://github.com/oap-project/oap-mllib/issues

Then could you also rename pull request title and commit log in the following format?

[ML-${ISSUES_ID}] ${detailed message}

See also:

@xwu99 xwu99 linked an issue Mar 19, 2021 that may be closed by this pull request
[Release] Revert to old oneCCL and Prepare for OAP 1.1 #41
Closed
@xwu99 xwu99 changed the title Revert to old oneCCL and Prepare for OAP 1.1 [ML-41] Revert to old oneCCL and Prepare for OAP 1.1 Mar 19, 2021
@github-actions
Copy link

#41

@xwu99 xwu99 added the OAP 1.1 label Mar 19, 2021
@xwu99 xwu99 mentioned this pull request Mar 19, 2021
Closed
@xwu99 xwu99 merged commit e539883 into oap-project:branch-1.1-spark-3.x Mar 23, 2021
@xwu99 xwu99 linked an issue Mar 30, 2021 that may be closed by this pull request
Branch "branch-1.1-spark-3.x" build failure #38
Closed
xwu99 added a commit that referenced this pull request Apr 15, 2021
@xwu99
Revert "[ML-41] Revert to old oneCCL and Prepare for OAP 1.1 (#40)"
51ecca1 
This reverts commit e539883.
@xwu99 xwu99 mentioned this pull request Apr 15, 2021
Merged
xwu99 added a commit that referenced this pull request Apr 15, 2021
@xwu99
Revert "[ML-41] Revert to old oneCCL and Prepare for OAP 1.1 (#40)" (#49
f637bfc 
)

This reverts commit e539883.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
OAP 1.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Release] Revert to old oneCCL and Prepare for OAP 1.1 Branch "branch-1.1-spark-3.x" build failure
1 participant
@xwu99