Skip to content
This repository has been archived by the owner on Sep 18, 2023. It is now read-only.

[NSE-955] implement lpad/rpad #964

Merged
merged 6 commits into from
Jun 14, 2022
Merged

[NSE-955] implement lpad/rpad #964

merged 6 commits into from
Jun 14, 2022

Conversation

zhouyuan
Copy link
Collaborator

@zhouyuan zhouyuan commented Jun 9, 2022

What changes were proposed in this pull request?

This patch implements lpad/rpad
Signed-off-by: Yuan Zhou [email protected]

How was this patch tested?

pass jenkins

@github-actions
Copy link

github-actions bot commented Jun 9, 2022

#955

@PHILO-HE
Copy link
Collaborator

We need also add some checks in containsSubquery for these two new expressions.

@PHILO-HE
Copy link
Collaborator

Jenkins UT passed except one ignorable failure (due to arrow branch is not rebased).

This reverts commit 8a51285.
@PHILO-HE PHILO-HE merged commit 81a1a9e into oap-project:main Jun 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants