This repository has been archived by the owner on Sep 18, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 75
[NSE-848] Optimize performance for Column2Row #849
Closed
zhixingheyi-tian
wants to merge
19
commits into
oap-project:master
from
zhixingheyi-tian:optimizeC2R
Closed
[NSE-848] Optimize performance for Column2Row #849
zhixingheyi-tian
wants to merge
19
commits into
oap-project:master
from
zhixingheyi-tian:optimizeC2R
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhixingheyi-tian
force-pushed
the
optimizeC2R
branch
from
April 20, 2022 02:00
82ae62e
to
bd323b0
Compare
FelixYBW
suggested changes
May 1, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be >1. 1 is Bool type. The code below can't can't process bool type data. Bool should be implemented specificly.
@FelixYBW So 1 is Int_8 type. |
@FelixYBW Still in reproducing and investigating in Local dev environment. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)