Skip to content
This repository has been archived by the owner on Sep 18, 2023. It is now read-only.

[NSE-848] Optimize performance for Column2Row #849

Closed

Conversation

zhixingheyi-tian
Copy link
Collaborator

What changes were proposed in this pull request?

(Please fill in changes proposed in this fix)

How was this patch tested?

(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)

(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)

@github-actions
Copy link

#848

Copy link
Collaborator

@FelixYBW FelixYBW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be >1. 1 is Bool type. The code below can't can't process bool type data. Bool should be implemented specificly.

@zhixingheyi-tian
Copy link
Collaborator Author

It should be >1. 1 is Bool type. The code below can't can't process bool type data. Bool should be implemented specificly.

@FelixYBW
typewidth[col_index] = arrow::bit_width(typevec[col_index]) >> 3;
when col_index is Bool column , typewidth[col_index] is 0.

So 1 is Int_8 type.

@zhixingheyi-tian
Copy link
Collaborator Author

@FelixYBW
For jenkins TPCH workload, encounter executor restarted issues.

Still in reproducing and investigating in Local dev environment.

@weiting-chen weiting-chen deleted the branch oap-project:master May 7, 2022 07:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants