This repository has been archived by the owner on Sep 18, 2023. It is now read-only.
[NSE-772] Code refactor for ColumnarBatchScan #805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/oap-project/native-sql-engine/issues Then could you also rename commit message and pull request title in the following format? See also: |
PHILO-HE
changed the title
zhouyuan
approved these changes
Mar 29, 2022
zhouyuan
pushed a commit
to zhouyuan/native-sql-engine
that referenced
this pull request
Mar 30, 2022
* Override doCanonicalize in ColumnarBatchScanExec * Refactor ColumnarBatchScan
zhouyuan
added a commit
that referenced
this pull request
Mar 30, 2022
* [NSE-772] Code refactor for ColumnarBatchScan (#805) * Override doCanonicalize in ColumnarBatchScanExec * Refactor ColumnarBatchScan * [NSE-778] Failed to find include file while running code gen (#779) * fix can not find include file * add maven test content back Co-authored-by: PHILO-HE <[email protected]> Co-authored-by: Jacky Lee <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Refactor ColumnarBatchScan. Prior to this work, an anonymous class is used to create the object, which will lead to the operator is named like $anon$1 in DAG (spark will get operator's class name and replace "exec" with "" to name the node).
How was this patch tested?
No regression issue is expected in unit tests/benchmark test.