This repository has been archived by the owner on Sep 18, 2023. It is now read-only.
[NSE-795] Fix a consecutive SMJ issue in wscg #798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PHILO-HE
force-pushed
the
spark3.2-smj-wscg
branch
from
70c8584 to
1ea3c17
Compare
|
For a SMJ whose children are both SMJ, putting them into a wscg will lead to a native error (set dependency error). In this patch, I simply move the parent SMJ into the outside of wscg.
|
PHILO-HE
changed the title
PHILO-HE
force-pushed
the
spark3.2-smj-wscg
branch
from
4bd9475 to
8cd1282
Compare
zhouyuan
reviewed
Mar 28, 2022
| assert(ex.head.child.isInstanceOf[ColumnarBroadcastExchangeAdaptor]) | ||
| // FIXME: ignore DPP xchg reuse | ||
| //assert(ex.nonEmpty) | ||
| //assert(ex.head.child.isInstanceOf[ColumnarBroadcastExchangeAdaptor]) |
There was a problem hiding this comment.
the tests are ignored until we fix the columnarSubqueryBoradcast gap
PHILO-HE
force-pushed
the
spark3.2-smj-wscg
branch
from
7166b7d to
c91cac0
Compare
Signed-off-by: Yuan Zhou <[email protected]>
zhouyuan
added a commit
to zhouyuan/native-sql-engine
that referenced
this pull request
Mar 28, 2022
* Break whole stage code gen for consecutive SMJ * Check optimized operation in wscg * Add special handling for consecutive SMJ * Undo a piece of code changes * ignore DPP xchg reuse Signed-off-by: Yuan Zhou <[email protected]> Co-authored-by: Yuan Zhou <[email protected]>
zhouyuan
added a commit
that referenced
this pull request
Mar 28, 2022
* Break whole stage code gen for consecutive SMJ * Check optimized operation in wscg * Add special handling for consecutive SMJ * Undo a piece of code changes * ignore DPP xchg reuse Signed-off-by: Yuan Zhou <[email protected]> Co-authored-by: Yuan Zhou <[email protected]> Co-authored-by: PHILO-HE <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is not supported to have two or more SMJ consecutively executed in a whole stage code gen.