This repository has been archived by the owner on Sep 18, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 75
[NSE-758] Upgrade to spark 3.1.3 from 3.1.1 #756
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/oap-project/native-sql-engine/issues Then could you also rename commit message and pull request title in the following format?
See also: |
PHILO-HE
changed the title
Allow spark 3.1.2 pass the version check in shim layer
Add spark-3.1.2 as supported version for spark-3.1.1 shim layer
Mar 9, 2022
PHILO-HE
changed the title
Add spark-3.1.2 as supported version for spark-3.1.1 shim layer
Add spark-3.1.2 as another supported version for spark-3.1.1 shim layer
Mar 9, 2022
zhouyuan
reviewed
Mar 9, 2022
val DESCRIPTOR_STRINGS = Seq(s"$DESCRIPTOR") | ||
val SPARK311_DESCRIPTOR = SparkShimDescriptor(3, 1, 1) | ||
val SPARK312_DESCRIPTOR = SparkShimDescriptor(3, 1, 2) | ||
val DESCRIPTOR_STRINGS = Seq(s"$SPARK311_DESCRIPTOR", s"$SPARK312_DESCRIPTOR") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3.1.* should be better
PHILO-HE
changed the title
Add spark-3.1.2 as another supported version for spark-3.1.1 shim layer
[NSE-758] Upgrade to spark 3.1.3 from 3.1.1
Mar 10, 2022
There are some compatibility issues in upgrading 3.1.1 to 3.1.3.
|
To make gazelle workable on spark 3.1.2 & 3.1.3, we already have a quick fix in #760 by allowing loading 3.1.1 shim layer for 3.1.2 & 3.1.3 at runtime. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to Jin Hao's feedback, spark-3.1.2 is the version we used in runtime env. for perf. test, even though spark-3.1.1 is the imported dependency version. Maybe, for spark-3.1.1 shim layer, spark-3.1.2 should also be supported.