This repository has been archived by the owner on Sep 18, 2023. It is now read-only.
[NSE-745] Improve codegen check for expression #751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhouyuan
force-pushed
the
wip_codegen_expr
branch
from
00db992 to
1de4639
Compare
This patch addes more codegen check on exprs. The parent operator will be marked support codegen only all its expressions support codegen. Signed-off-by: Yuan Zhou <[email protected]>
Signed-off-by: Yuan Zhou <[email protected]>
|
note: this patch only adds checking on a few expressions, will update more in next patch |
weiting-chen
added
bug
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This patch addes more codegen check on exprs. The parent operator
will be marked support codegen only all its expressions support
codegen.
Signed-off-by: Yuan Zhou [email protected]
How was this patch tested?
pass jenkins