This repository has been archived by the owner on Sep 18, 2023. It is now read-only.
[NSE-550] Support ORC Format Reading in Gazelle #551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhixingheyi-tian
changed the title
|
note: depends on oap-project/arrow#42 |
|
@zhixingheyi-tian please also add this commit |
zhouyuan
reviewed
Nov 8, 2021
| @@ -47,7 +47,7 @@ jobs: | |||
| git clone https://github.com/oap-project/arrow.git | |||
| cd arrow && git checkout arrow-4.0.0-oap && cd cpp | |||
| mkdir build && cd build | |||
| cmake .. -DARROW_JNI=ON -DARROW_GANDIVA_JAVA=ON -DARROW_GANDIVA=ON -DARROW_PARQUET=ON -DARROW_CSV=ON -DARROW_HDFS=ON -DARROW_FILESYSTEM=ON -DARROW_WITH_SNAPPY=ON -DARROW_JSON=ON -DARROW_DATASET=ON -DARROW_WITH_LZ4=ON -DGTEST_ROOT=/usr/src/gtest && make -j2 | |||
| cmake .. -DARROW_JNI=ON -DARROW_GANDIVA_JAVA=ON -DARROW_GANDIVA=ON -DARROW_PARQUET=ON -DARROW_ORC=ON -DARROW_CSV=ON -DARROW_HDFS=ON -DARROW_FILESYSTEM=ON -DARROW_WITH_SNAPPY=ON -DARROW_JSON=ON -DARROW_DATASET=ON -DARROW_WITH_LZ4=ON -DGTEST_ROOT=/usr/src/gtest && make -j2 | |||
There was a problem hiding this comment.
please also add this to the default packaging
https://github.com/oap-project/gazelle_plugin/blob/master/arrow-data-source/script/build_arrow.sh#L73
There was a problem hiding this comment.
Add -DARROW_ORC=ON again for remaining 6 files.
zhouyuan
approved these changes
Nov 9, 2021
|
@zhixingheyi-tian thanks for the quick work, merging first |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Support ORC Format Reading in Gazelle. Follow issue #550 .
How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)