This repository has been archived by the owner on Sep 18, 2023. It is now read-only.
[NSE-254]Fix redundant arrow library issue. #452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhouyuan
reviewed
Aug 5, 2021
| @@ -214,45 +214,45 @@ macro(build_arrow STATIC_ARROW) | |||
| else() | |||
|
|
|||
| # Copy Arrow Shared Library to releases directory for package jar | |||
| ExternalProject_Add_Step(arrow_ep copy_arrow_binary | |||
| #ExternalProject_Add_Step(arrow_ep copy_arrow_binary | |||
There was a problem hiding this comment.
Yes, I commit a new one to remove the marked code.
zhouyuan
approved these changes
Aug 6, 2021
|
@weiting-chen |
zhouyuan
pushed a commit
to zhouyuan/native-sql-engine
that referenced
this pull request
Aug 8, 2021
* [NSE-254]Fix redundant arrow library issue. * remote the unneccessary marked code
zhouyuan
added a commit
that referenced
this pull request
Aug 9, 2021
* [NSE-254]Fix redundant arrow library issue. (#452) * [NSE-254]Fix redundant arrow library issue. * remote the unneccessary marked code * remove arrow-data-source-common from jar with dependency (#453) native sql engine is bundled with arrow data source now so it should be safe to assume those dataset related class will be 'pre-loaded' with this fix the jar size is ~97MB(was ~147MB) on my local env Signed-off-by: Yuan Zhou <[email protected]> Co-authored-by: Wei-Ting Chen <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix redundant so file pack into jar file.
How was this patch tested?
Already pass TPC-H q1~q5 testing on the local server with below two compile commands.