Skip to content
This repository has been archived by the owner on Sep 18, 2023. It is now read-only.

[NSE-362] use arrow-unsafe allocator by default #363

Merged
merged 1 commit into from
Jun 15, 2021

Conversation

zhouyuan
Copy link
Collaborator

What changes were proposed in this pull request?

This patch makes arrow-unsafe allocator as default profile

arrow-netty will instance netty memory pool to reduce the
alloc/dealloc overhead which introduced big memory footprint.

local perf tests showed the performace is not heavily impacted
after switch to arrow-unsafe

one more benefit is we could remove the -XX:MaxDirectMemorySize flag
which also impacts the vanilla Spark memory usage

Signed-off-by: Yuan Zhou [email protected]
fixes #362

How was this patch tested?

locally verified

@github-actions
Copy link

#362

This patch makes arrow-unsafe allocator as default profile

arrow-netty will instance netty memory pool to reduce the
alloc/dealloc overhead which introduced big memory footprint.

local perf tests showed the performace is not heavily impacted
after switch to arrow-unsafe

one more benefit is we could remove the -XX:MaxDirectMemorySize flag
which also impacts the vanilla Spark memory usage

Signed-off-by: Yuan Zhou <[email protected]>
@zhouyuan zhouyuan merged commit 6d7511d into oap-project:master Jun 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make arrow-unsafe allocator as the default
1 participant