This repository has been archived by the owner on Sep 18, 2023. It is now read-only.
[NSE-207] fix issues found in scala unit tests #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rui-mo
commented
Jun 18, 2021
| @@ -459,7 +459,7 @@ class CountLiteralAction : public ActionBase { | |||
|
|
|||
| // prepare evaluate lambda | |||
| *on_valid = [this](int dest_group_id) { | |||
| cache_[dest_group_id] += arg_; | |||
| cache_[dest_group_id] += 1; | |||
There was a problem hiding this comment.
For count_literal, why do we add the arg to final result?
rui-mo
commented
Jun 18, 2021
| << tmp_name << ".array_id, " << tmp_name << ".id));" << std::endl; | ||
| valid_ss << output_validity << " = !" << is_outer_null_name << " && !(" << name | ||
| << "_has_null && " << name << "->IsNull(" << tmp_name << ".array_id, " | ||
| << tmp_name << ".id));" << std::endl; |
There was a problem hiding this comment.
define them as global variables
rui-mo
commented
Jun 18, 2021
| } | ||
| } | ||
| return unique_defines; | ||
| } |
There was a problem hiding this comment.
remove duplicated definitions
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This pr fixed some issues found in scala unit tests, mainly including:
#207
How was this patch tested?
verified on TPC-DS v1, v2 is under test