Skip to content
This repository has been archived by the owner on Sep 18, 2023. It is now read-only.

[NSE-343]allow to config codegen opt level #344

Merged
merged 2 commits into from
Jun 1, 2021
Merged

[NSE-343]allow to config codegen opt level #344

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d70186
allow to config codegen opt level
zhouyuan May 27, 2021
809fb5c
fix format
zhouyuan May 31, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions native-sql-engine/cpp/src/codegen/arrow_compute/ext/codegen_common.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -548,6 +548,13 @@ arrow::Status CompileCodes(std::string codes, std::string signature) {
}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changing const char* seems wrong

std::string env_gcc = std::string(env_gcc_);

char* env_codegen_option_ = std::getenv("CODEGEN_OPTION");

if (env_codegen_option_ == nullptr) {
env_codegen_option_ = " -O3 -march=native ";
}
std::string env_codegen_option = std::string(env_codegen_option_);

const char* env_arrow_dir = std::getenv("LIBARROW_DIR");
std::string arrow_header;
std::string arrow_lib, arrow_lib2;
Expand All @@ -563,8 +570,8 @@ arrow::Status CompileCodes(std::string codes, std::string signature) {
// compile the code
std::string cmd = env_gcc + " -std=c++14 -Wno-deprecated-declarations " + arrow_header +
arrow_lib + arrow_lib2 + nativesql_header + nativesql_header_2 +
nativesql_lib + cppfile + " -o " + libfile +
" -O3 -march=native -shared -fPIC -lspark_columnar_jni 2> " + logfile;
nativesql_lib + cppfile + " -o " + libfile + env_codegen_option +
" -shared -fPIC -lspark_columnar_jni 2> " + logfile;
#ifdef DEBUG
std::cout << cmd << std::endl;
#endif
Expand All @@ -577,10 +584,7 @@ arrow::Status CompileCodes(std::string codes, std::string signature) {
if (WEXITSTATUS(ret) != EXIT_SUCCESS) {
std::cout << "compilation failed, see " << logfile << std::endl;
std::cout << cmd << std::endl;
/*cmd = "ls -R -l " + GetTempPath() + "; cat " + logfile;
system(cmd.c_str());*/
return arrow::Status::Invalid("compilation failed, see ", logfile);
// exit(EXIT_FAILURE);
}
cmd = "cd " + outpath + "; jar -cf spark-columnar-plugin-codegen-precompile-" +
signature + ".jar spark-columnar-plugin-codegen-" + signature + ".so";
Expand Down