Skip to content
This repository has been archived by the owner on Sep 18, 2023. It is now read-only.

[NSE-285] ColumnarWindow: Support Date input in MAX/MIN #286

Merged
merged 5 commits into from
May 8, 2021

Conversation

zhztheplayer
Copy link
Collaborator

What changes were proposed in this pull request?

(Please fill in changes proposed in this fix)

How was this patch tested?

(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)

(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)

@github-actions
Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/oap-project/native-sql-engine/issues

Then could you also rename commit message and pull request title in the following format?

[NSE-${ISSUES_ID}] ${detailed message}

See also:

@zhztheplayer zhztheplayer marked this pull request as draft April 26, 2021 11:20
@zhztheplayer zhztheplayer changed the title [DNM][NSE-285] ColumnarWindow: Support Date/Timestamp input in MAX/MIN [NSE-285] ColumnarWindow: Support Date/Timestamp input in MAX/MIN Apr 30, 2021
@zhztheplayer zhztheplayer marked this pull request as ready for review April 30, 2021 07:18
@github-actions
Copy link

#285

@zhztheplayer zhztheplayer changed the title [NSE-285] ColumnarWindow: Support Date/Timestamp input in MAX/MIN [NSE-285] ColumnarWindow: Support Date input in MAX/MIN Apr 30, 2021
@zhztheplayer
Copy link
Collaborator Author

@github-actions ram-usage-test

@zhztheplayer
Copy link
Collaborator Author

Reopening this to pick newest CI settings

@zhztheplayer zhztheplayer reopened this May 8, 2021
@zhztheplayer
Copy link
Collaborator Author

@github-actions ram-usage-test

@zhztheplayer
Copy link
Collaborator Author

@github-actions ram-usage-test

@github-actions
Copy link

github-actions bot commented May 8, 2021


@zhztheplayer zhztheplayer merged commit b6c267a into oap-project:master May 8, 2021
zhouyuan added a commit that referenced this pull request May 13, 2021
* [NSE-262] fix remainer loss in decimal divide (#263)

* fix decimal divide int issue

* correct cpp uts

* use const reference

Co-authored-by: Yuan <[email protected]>

Co-authored-by: Yuan <[email protected]>

* [NSE-261] ArrowDataSource: Add S3 Support (#270)

Closes #261

* [NSE-196] clean up configs in unit tests (#271)

* remove testing config

* remove unused configs

* [NSE-265] Reserve enough memory before UnsafeAppend in builder (#266)

* change the UnsafeAppend to Append

* fix buffer builder in shuffle

shuffle builder use UnsafeAppend API for better performance. it
tries to reserve enough space based on results of last recordbatch,
this maybe not buggy if there's a dense recordbatch after a sparse one.

this patch adds below fixes:
- adds Reset() after Finish() in builder
- reserve length for offset_builder in binary builder

A further clean up on the reservation logic should be needed.

Signed-off-by: Yuan Zhou <[email protected]>

Co-authored-by: Yuan Zhou <[email protected]>

* [NSE-274] Comment to trigger tpc-h RAM test (#275)

Closes #274

* bump cmake to 3.16 (#281)

Signed-off-by: Yuan Zhou <[email protected]>

* [NSE-276] Add option to switch Hadoop version (#277)

Closes #276

* [NSE-119] clean up on comments (#288)

Signed-off-by: Yuan Zhou <[email protected]>

* [NSE-206]Update installation guide and configuration guide. (#289)

* [NSE-206]Update installation guide and configuration guide.

* Fix numaBinding setting issue. & Update description for protobuf

* [NSE-206]Fix Prerequisite and Arrow Installation Steps. (#290)

* [NSE-245]Adding columnar RDD cache support (#246)

* Adding columnar RDD cache support

Signed-off-by: Chendi Xue <[email protected]>

* Directly save reference, only convert to Array[Byte] when calling by BlockManager

Signed-off-by: Chendi Xue <[email protected]>

* Add DeAllocator to construction to make sure this instance will be released once it be deleted by JVM

Signed-off-by: Chendi Xue <[email protected]>

* Delete cache by adding a release in InMemoryRelation

Since unpersist only delete RDD object, seems our deAllocator wasn't being called along
Now we added a release function in InMemoryRelation clearCache() func, may need to think
a new way for 3.1.0

Signed-off-by: Chendi Xue <[email protected]>

* [NSE-207] fix issues found from aggregate unit tests (#233)

* fix incorrect input in Expand

* fix empty input for aggregate

* fix only result expressions

* fix empty aggregate expressions

* fix res attr not found issue

* refine

* fix count distinct with null

* fix groupby of NaN, -0.0 and 0.0

* fix count on mutiple cols with null in WSCG

* format code

* support normalize NaN and 0.0

* revert and update

* support normalize function in WSCG

* [NSE-206]Update documents and License for 1.1.0 (#292)

* [NSE-206]Update documents and remove duplicate parts

* Modify documents by comments

* [NSE-293] fix unsafemap with key = '0' (#294)

Signed-off-by: Yuan Zhou <[email protected]>

* [NSE-257] fix multiple slf4j bindings (#291)

* [NSE-297] Disable incremental compiler in GHA CI (#298)

Closes #297

* [NSE-285] ColumnarWindow: Support Date input in MAX/MIN (#286)

Closes #285

* [NSE-304] Upgrade to Arrow 4.0.0: Change basic GHA TPC-H test target OAP Arrow branch (#306)

* [NSE-302] remove exception (#303)

* [NSE-273] support spark311 (#272)

* support spark 3.0.2

Signed-off-by: Yuan Zhou <[email protected]>

* update to use spark 302 in unit tests

Signed-off-by: Yuan Zhou <[email protected]>

* support spark 311

Signed-off-by: Yuan Zhou <[email protected]>

* fix

Signed-off-by: Yuan Zhou <[email protected]>

* fix missing dep

Signed-off-by: Yuan Zhou <[email protected]>

* fix broadcastexchange metrics

Signed-off-by: Yuan Zhou <[email protected]>

* fix arrow data source

Signed-off-by: Yuan Zhou <[email protected]>

* fix sum with decimal

Signed-off-by: Yuan Zhou <[email protected]>

* fix c++ code

Signed-off-by: Yuan Zhou <[email protected]>

* adding partial sum decimal sum

Signed-off-by: Yuan Zhou <[email protected]>

* fix hashagg in wscg

Signed-off-by: Yuan Zhou <[email protected]>

* fix partial sum with number type

Signed-off-by: Yuan Zhou <[email protected]>

* fix AQE shuffle copy

Signed-off-by: Yuan Zhou <[email protected]>

* fix shuffle redudant reat

Signed-off-by: Yuan Zhou <[email protected]>

* fix rebase

Signed-off-by: Yuan Zhou <[email protected]>

* fix format

Signed-off-by: Yuan Zhou <[email protected]>

* avoid unecessary fallbacks

Signed-off-by: Yuan Zhou <[email protected]>

* on-demand scala unit tests

Signed-off-by: Yuan Zhou <[email protected]>

* clean up

Signed-off-by: Yuan Zhou <[email protected]>

* [NSE-311] Build reports errors (#312)

Closes #311

* [NSE-257] fix the dependency issue on v2

Co-authored-by: Rui Mo <[email protected]>
Co-authored-by: Hongze Zhang <[email protected]>
Co-authored-by: JiaKe <[email protected]>
Co-authored-by: Wei-Ting Chen <[email protected]>
Co-authored-by: Chendi.Xue <[email protected]>
Co-authored-by: Hong <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant