This repository has been archived by the owner on Sep 18, 2023. It is now read-only.
[NSE-27]Reuse exchage to optimize DPP performance #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xuechendi
changed the title
|
|
xuechendi
force-pushed
the
wip_reuse_broadcastexchange_in_dpp
branch
from
bbe68e9 to
ee63f8b
Compare
|
|
Signed-off-by: Chendi Xue <[email protected]>
xuechendi
force-pushed
the
wip_reuse_broadcastexchange_in_dpp
branch
from
ee63f8b to
50e7db0
Compare
1. besides, also changed ColumnarUnionExec as case class Signed-off-by: Chendi Xue <[email protected]>
|
|
when AQE enabled, it only accept ShuffleExchangeExec and BroadcastExchangeExec, so if we use case class for ColumnarShuffleExchangeExec and ColumnarBroadcastExchangeExec, it will go exception in AQE To fix this, we add a shadow class who extends ShuffleExchangeExec or BroadcastExchangeExec while actually call ColumnarShuffleExchangeExec and ColumnarBroadcastExchangeExec implementation Then we will use supportAdaptive check to see if we should instantiate shadow class or case class to both support DPP and AQE Signed-off-by: Chendi Xue <[email protected]>
xuechendi
force-pushed
the
wip_reuse_broadcastexchange_in_dpp
branch
2 times, most recently
from
5be82df to
d433318
Compare
|
|
xuechendi
changed the title
|
|
Signed-off-by: Chendi Xue <[email protected]>
|
@zhouyuan , updated, now it will check if SQLConf.get.adaptiveExecutionEnabled is true in supportAdaptive function. |
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Chendi Xue [email protected]
Fixed: #27
verified with tpcds_v1_sf500_dpp and tpcds_v2_sf500