This repository has been archived by the owner on Sep 18, 2023. It is now read-only.
[NSE-185] Avoid unnecessary copying when simply projecting on fields #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
zhztheplayer
changed the title
|
This would be problematic when a project emits multiple columns from the same column. Say: A fix is needed |
|
|
zhouyuan
changed the title
|
@zhouyuan I've verified this with TPC-DS Q1~Q20 and TPC-DS Q67. I'm running a complete TPC-DS test now and I think we can merge/backport this anytime we think is needed. And any further troubles I'll log to here and we can then perform rollback. |
zhouyuan
approved these changes
Mar 26, 2021
zhouyuan
pushed a commit
to zhouyuan/native-sql-engine
that referenced
this pull request
Mar 30, 2021
…ap-project#187) * [NSE-185] Avoid unnecessary copying when simply projecting on fields * Avoid sharing buffers in output
zhouyuan
added a commit
that referenced
this pull request
Apr 2, 2021
* [NSE-185] Avoid unnecessary copying when simply projecting on fields (#187) * [NSE-185] Avoid unnecessary copying when simply projecting on fields * Avoid sharing buffers in output * [NSE-211] IndexOutOfBoundsException during running TPC-DS Q2 (#212) Closes #211 * fix missing decimal check (#219) Signed-off-by: Yuan Zhou <[email protected]> * [NSE-227]fix issues from codescan (#225) * fix code scan Signed-off-by: Yuan Zhou <[email protected]> * fix code scan * fix format Signed-off-by: Yuan Zhou <[email protected]> * fix wrong patch Signed-off-by: Yuan Zhou <[email protected]> * Klockwork issues fix * fix format Signed-off-by: Yuan Zhou <[email protected]> * more fixes Signed-off-by: Yuan Zhou <[email protected]> Co-authored-by: Rui Mo <[email protected]> Co-authored-by: Hongze Zhang <[email protected]> * allow to config batchsize in hashagg and wscg (#222) Signed-off-by: Yuan Zhou <[email protected]> Co-authored-by: Hongze Zhang <[email protected]> Co-authored-by: Rui Mo <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to fix inefficient columnar project executions brought by PR #151 . Other queries that result in field projections may also be accelerated (untested).