Skip to content
This repository has been archived by the owner on Sep 18, 2023. It is now read-only.

[NSE-125] Add C++ unit tests to CI #133

Merged
merged 3 commits into from
Feb 26, 2021
Merged

Conversation

zhztheplayer
Copy link
Collaborator

No description provided.

@github-actions
Copy link

#125

@zhztheplayer
Copy link
Collaborator Author

@zhouyuan Let's use this approach at this time. And in future we can add gtest installation into CMake configuration to get better compatibility.

@zhztheplayer
Copy link
Collaborator Author

CI failure message is:

97% tests passed, 3 tests failed out of 88

Total Test time (real) =  96.85 sec

The following tests FAILED:
	 61 - TestArrowComputeWSCG.WSCGTestContinuousMergeJoinSemiExistenceWithCondition (Failed)
Errors while running CTest
	 66 - TestArrowComputeWSCG.WSCGTestStringMergeInnerJoinWithGroupbyAggregate (Failed)
	 81 - TestArrowComputeWSCG.JoinWOCGTestInnerJoinType2WithUInt16 (Failed)
Error: Process completed with exit code 8.

@github-actions
Copy link


@zhouyuan
Copy link
Collaborator

zhouyuan commented Feb 25, 2021

@zhztheplayer

thanks, i'll try to make a patch for this.
can you please cherry pick this change to fix the ut?
zhouyuan@45924d8

Signed-off-by: Yuan Zhou <[email protected]>
@zhouyuan
Copy link
Collaborator

@zhztheplayer
it looks like the version of gtest is a bit old. can you please manually comment out this test?
https://github.com/oap-project/native-sql-engine/blob/master/cpp/src/tests/arrow_compute_test_join_wocg.cc#L1740

/home/runner/work/native-sql-engine/native-sql-engine/cpp/src/tests/arrow_compute_test_join_wocg.cc:1741:3: error: ‘GTEST_SKIP’ was not declared in this scope
   GTEST_SKIP(); //TODO() fix this test
   ^~~~~~~~~~
/home/runner/work/native-sql-engine/native-sql-engine/cpp/src/tests/arrow_compute_test_join_wocg.cc:1741:3: note: suggested alternative: ‘GTEST_API_’
   GTEST_SKIP(); //TODO() fix this test
   ^~~~~~~~~~
   GTEST_API_

@github-actions
Copy link


@github-actions
Copy link


@zhouyuan zhouyuan merged commit e1e4b73 into oap-project:master Feb 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants