Skip to content
This repository has been archived by the owner on Sep 18, 2023. It is now read-only.

Remove project from wscg when it's the child of window #1136

Merged
merged 1 commit into from
Oct 21, 2022

Conversation

jackylee-ch
Copy link
Contributor

What changes were proposed in this pull request?

We meet the RecordBatch must be non-empty problem when there is a ColumnarWindowExec after WSCG and there is a ColumnarConditionProjectExec as a child of ColumnarWindowExec. It help use when we tried to remove the ColumnarConditionProjectExec from WSCG.

How was this patch tested?

unit tests and manual test.

@github-actions
Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/oap-project/native-sql-engine/issues

Then could you also rename commit message and pull request title in the following format?

[NSE-${ISSUES_ID}] ${detailed message}

See also:

@zhouyuan
Copy link
Collaborator

@jackylee-ch thanks for the quick fix!

@zhouyuan zhouyuan changed the title [WIP] Remove project from wscg when it's the child of window Remove project from wscg when it's the child of window Oct 21, 2022
@zhouyuan zhouyuan merged commit 00ed950 into oap-project:main Oct 21, 2022
@jackylee-ch jackylee-ch deleted the fix_wscg_work_with_window branch October 21, 2022 02:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants