Skip to content
This repository has been archived by the owner on Sep 18, 2023. It is now read-only.

[NSE-1104] fix hashagg w/ empty string #1099

Merged
merged 3 commits into from
Sep 8, 2022

Conversation

zhouyuan
Copy link
Collaborator

@zhouyuan zhouyuan commented Sep 5, 2022

What changes were proposed in this pull request?

This patch fixes one case of hashagg wrong results over multiple columns
group by col_a, col_b

col_a col_b
"ab" "ab"
"a" "bab"
"aba" "b"
"abab" ""

The fix introduced a new is_empty field to tell whether some columns are empty string, which can fix the issue on last row

Signed-off-by: Yuan Zhou [email protected]

How was this patch tested?

new unit tests

@github-actions
Copy link

github-actions bot commented Sep 5, 2022

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/oap-project/native-sql-engine/issues

Then could you also rename commit message and pull request title in the following format?

[NSE-${ISSUES_ID}] ${detailed message}

See also:

Signed-off-by: Yuan Zhou <[email protected]>
@zhouyuan zhouyuan changed the title fix hashagg w/ empty string [NSE-1104] fix hashagg w/ empty string Sep 7, 2022
@zhouyuan zhouyuan marked this pull request as ready for review September 7, 2022 12:59
@github-actions
Copy link

github-actions bot commented Sep 7, 2022

#1104

@zhouyuan zhouyuan merged commit 3ee659c into oap-project:main Sep 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant