-
Notifications
You must be signed in to change notification settings - Fork 75
[NSE-1019] fix codegen for all expressions #1039
Conversation
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/oap-project/native-sql-engine/issues Then could you also rename commit message and pull request title in the following format?
See also: |
It looks ColumnarFromUnixTime also has a similar issue. |
let me see if we could mark the default codegen support as false |
Signed-off-by: Yuan Zhou <[email protected]>
Signed-off-by: Yuan Zhou <[email protected]>
24af8bc
to
5de484f
Compare
Signed-off-by: Yuan Zhou <[email protected]>
976a0a2
to
41e530d
Compare
"get_json_object", | ||
"translate", | ||
"substr", | ||
"instr", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like instr
should be replaced by locate
here and in expression_codegen_visitor.cc
. Please refer to the code in ColumnarStringInstr
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed in 7f38a8e
native-sql-engine/core/src/main/scala/com/intel/oap/expression/ColumnarExpression.scala
Show resolved
Hide resolved
Signed-off-by: Yuan Zhou <[email protected]>
Signed-off-by: Yuan Zhou <[email protected]>
Signed-off-by: Yuan Zhou <[email protected]>
Signed-off-by: Yuan Zhou <[email protected]>
1580309
to
7f38a8e
Compare
Signed-off-by: Yuan Zhou <[email protected]>
Signed-off-by: Yuan Zhou <[email protected]>
What changes were proposed in this pull request?
This patch adds
supportColumnarCodegen
for all functionsSigned-off-by: Yuan Zhou [email protected]
How was this patch tested?
pass jenkins