Skip to content
This repository has been archived by the owner on Sep 18, 2023. It is now read-only.

[NSE-1027] Problem with Literal in window function #1028

Merged

Conversation

jackylee-ch
Copy link
Contributor

What changes were proposed in this pull request?

We didn't consider Literal type in window functions, espetially while partitioning by Literal in window functions.
Here is an example problem SQL select col_lit, b, row_number() over (partition by col_lit, a order by int(b) asc) as c from (select "abc" as col_lit, a, b from test).

How was this patch tested?

origin tests

@github-actions
Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/oap-project/native-sql-engine/issues

Then could you also rename commit message and pull request title in the following format?

[NSE-${ISSUES_ID}] ${detailed message}

See also:

@jackylee-ch jackylee-ch changed the title [ASE-1027] Problem with Literal in window function [NSE-1027] Problem with Literal in window function Jul 18, 2022
@github-actions
Copy link

#1027

@zhouyuan zhouyuan merged commit 697e0de into oap-project:main Jul 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants