This repository has been archived by the owner on Sep 18, 2023. It is now read-only.
[NSE-955] Add Murmur3Hash expression support #1013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhouyuan
reviewed
Jul 6, 2022
| child.asInstanceOf[ColumnarExpression].doColumnarCodeGen(args) | ||
| val gandivaFuncName = child.dataType match { | ||
| case LongType => "hash64_spark" | ||
| case DoubleType => "hash64_spark" |
There was a problem hiding this comment.
for Long/Double, this will generating 64 bit hashes, not align with Spark?
There was a problem hiding this comment.
Sorry for this late reply. Just checked, "hash64_spark" function we used will return 32 bit values, compatible with Spark. Gandiva has function named "hash64" which return 64 bit values.
NativeFunction("hash64_spark", {}, DataTypeVector{int64(), int32()}, int32(),
kResultNullNever, "hash64_spark_int64_int32"),
NativeFunction("hash64_spark", {}, DataTypeVector{float64(), int32()}, int32(),
kResultNullNever, "hash64_spark_float64_int32"),
NativeFunction("hashbuf_spark", {}, DataTypeVector{utf8(), int32()}, int32(),
kResultNullNever, "hashbuf_spark_utf8_int32"),
|
UT & TPC-H/DS have passed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is for spark function named "hash" to get the murmur3 hash result for a given input.
How was this patch tested?
UT.