pass by ref in builder

Signed-off-by: Yuan Zhou <[email protected]>
oap-project · Mar 18, 2021 · fdc8777 · fdc8777
1 parent f42384d
commit fdc8777
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/native-sql-engine/cpp/src/precompile/builder.cc b/native-sql-engine/cpp/src/precompile/builder.cc
@@ -32,7 +32,7 @@ namespace precompile {
   };                                                                                    \
                                                                                         \
   TYPENAME::TYPENAME(arrow::MemoryPool* pool) { impl_ = std::make_shared<Impl>(pool); } \
-  arrow::Status TYPENAME::Append(CTYPE value) { return impl_->Append(value); }          \
+  arrow::Status TYPENAME::Append(const CTYPE& value) { return impl_->Append(value); }   \
   arrow::Status TYPENAME::AppendNull() { return impl_->AppendNull(); }                  \
   arrow::Status TYPENAME::Reserve(int64_t length) { return impl_->Reserve(length); }    \
   arrow::Status TYPENAME::AppendNulls(int64_t length) {                                 \

diff --git a/native-sql-engine/cpp/src/precompile/builder.h b/native-sql-engine/cpp/src/precompile/builder.h
@@ -24,7 +24,7 @@ namespace precompile {
   class TYPENAME {                                            \
    public:                                                    \
     TYPENAME(arrow::MemoryPool* pool);                        \
-    arrow::Status Append(TYPE val);                           \
+    arrow::Status Append(const TYPE& val);                    \
     arrow::Status AppendNull();                               \
     arrow::Status Reserve(int64_t);                           \
     arrow::Status AppendNulls(int64_t);                       \