optimize unique action

Signed-off-by: Yuan Zhou <[email protected]>
oap-project · Feb 21, 2022 · df95aca · df95aca
1 parent 144a354
commit df95aca
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 5 deletions.
diff --git a/native-sql-engine/cpp/src/codegen/arrow_compute/ext/actions_impl.cc b/native-sql-engine/cpp/src/codegen/arrow_compute/ext/actions_impl.cc
@@ -144,6 +144,7 @@ class UniqueAction : public ActionBase {
     if (cache_validity_.size() <= max_group_id) {
       cache_validity_.resize(max_group_id + 1, false);
       null_flag_.resize(max_group_id + 1, false);
+      cache_.resize(max_group_id + 1);
       length_ = cache_validity_.size();
     }
 
@@ -156,12 +157,13 @@ class UniqueAction : public ActionBase {
       if (cache_validity_[dest_group_id] == false) {
         if (!is_null) {
           cache_validity_[dest_group_id] = true;
-          cache_.emplace(cache_.begin() + dest_group_id, in_->GetView(row_id_));
+          cache_[dest_group_id] = (CType)in_->GetView(row_id_);
+          //cache_.emplace(cache_.begin() + dest_group_id, in_->GetView(row_id_));
         } else {
           cache_validity_[dest_group_id] = true;
           null_flag_[dest_group_id] = true;
-          CType num;
-          cache_.emplace(cache_.begin() + dest_group_id, num);
+          // CType num;
+          // cache_.emplace(cache_.begin() + dest_group_id, num);
         }
       }
       row_id_++;

diff --git a/native-sql-engine/cpp/src/codegen/arrow_compute/ext/hash_aggregate_kernel.cc b/native-sql-engine/cpp/src/codegen/arrow_compute/ext/hash_aggregate_kernel.cc
@@ -777,9 +777,9 @@ class HashAggregateKernel::Impl {
         }
       } else {
         for (int i = 0; i < length; i++) {
-          auto aggr_key = typed_key_in->GetView(i);
+
           aggr_hash_table_->GetOrInsert(
-              aggr_key, [](int) {}, [](int) {}, &(indices[i]));
+              typed_key_in->GetView(i), [](int) {}, [](int) {}, &(indices[i]));
         }
       }
 

diff --git a/native-sql-engine/cpp/src/jni/jni_common.h b/native-sql-engine/cpp/src/jni/jni_common.h
@@ -14,6 +14,7 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
+#pragma once
 
 #include <arrow/builder.h>
 #include <arrow/pretty_print.h>