Skip to content
This repository has been archived by the owner on Sep 18, 2023. It is now read-only.

Commit

Permalink
[NSE-955] Turn on the support for get_json_object (#1037)
Browse files Browse the repository at this point in the history
* Turn on the support for get_json_object

* Change arrow branch [will revert at last]

* Revert "Change arrow branch [will revert at last]"

This reverts commit 53b8fc8.
  • Loading branch information
PHILO-HE authored Jul 22, 2022
1 parent e7bb4e5 commit 8437145
Showing 1 changed file with 7 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,11 @@ class ColumnarGetJsonObject(left: Expression, right: Expression, original: GetJs
with ColumnarExpression
with Logging {

// TODO: currently we have a codegen implementation, but needs to be optimized.
override def supportColumnarCodegen(args: java.lang.Object): Boolean = {
false
}

override def doColumnarCodeGen(args: Object): (TreeNode, ArrowType) = {
var (left_node, left_type): (TreeNode, ArrowType) =
left.asInstanceOf[ColumnarExpression].doColumnarCodeGen(args)
Expand Down Expand Up @@ -131,8 +136,8 @@ object ColumnarBinaryExpression {
case d: DateSub =>
new ColumnarDateSub(left, right)
//TODO(): the current impl has poor perf
// case g: GetJsonObject =>
// new ColumnarGetJsonObject(left, right, g)
case g: GetJsonObject =>
new ColumnarGetJsonObject(left, right, g)
case instr: StringInstr =>
new ColumnarStringInstr(left, right, instr)
case other =>
Expand Down

0 comments on commit 8437145

Please sign in to comment.