Fix native ut issue

oap-project · Sep 28, 2022 · 49bfec0 · 49bfec0
1 parent 0f68a72
commit 49bfec0
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/native-sql-engine/cpp/src/codegen/arrow_compute/expr_visitor.cc b/native-sql-engine/cpp/src/codegen/arrow_compute/expr_visitor.cc
@@ -491,10 +491,13 @@ arrow::Status ExprVisitor::MakeExprVisitorImpl(
     partition_fields.push_back(field->field());
   }
   std::vector<gandiva::FieldPtr> order_fields;
-  for (std::shared_ptr<gandiva::Node> child : order_spec->children()) {
-    std::shared_ptr<gandiva::FieldNode> field =
-        std::dynamic_pointer_cast<gandiva::FieldNode>(child);
-    order_fields.push_back(field->field());
+  // order_spec is not required for all window functions. It can be null.
+  if (order_spec != nullptr) {
+    for (std::shared_ptr<gandiva::Node> child : order_spec->children()) {
+      std::shared_ptr<gandiva::FieldNode> field =
+          std::dynamic_pointer_cast<gandiva::FieldNode>(child);
+      order_fields.push_back(field->field());
+    }
   }
 
   std::vector<std::shared_ptr<arrow::DataType>> return_types;

diff --git a/native-sql-engine/cpp/src/codegen/arrow_compute/ext/window_kernel.cc b/native-sql-engine/cpp/src/codegen/arrow_compute/ext/window_kernel.cc
@@ -651,8 +651,7 @@ arrow::Status WindowLagKernel::Finish(ArrayList* out) {
     sorted_partitions.push_back(std::move(sorted_partition));
   }
 
-  ////// The above is almost as same as Rank's except using sort (order by) input for
-  ///sorter. ////////
+  // The above is almost as same as Rank's except using sort (order by) input for sorter. //
 
 #define PROCESS_SUPPORTED_COMMON_TYPES_LAG(PROC)                    \
   PROC(arrow::UInt8Type, arrow::UInt8Builder, arrow::UInt8Array)    \