fix coredump issue when client not successfully connected but need disconnect #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW Opening JIRAs ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename pull request title in the following format? or See also: |
|
@jikunshang Please take a review. Thanks. |
jikunshang
approved these changes
Jul 30, 2021
| @@ -35,13 +36,27 @@ | |||
|
|
|||
| private final long conn; | |||
|
|
|||
| private PlasmaClientException plasmaClientException = null; | |||
There was a problem hiding this comment.
use a flag rather than Exception?
There was a problem hiding this comment.
updated with using a flag instead.
| protected void finalize() { | ||
| PlasmaClientJNI.disconnect(this.conn); | ||
| if (plasmaClientException == null) { | ||
| PlasmaClientJNI.disconnect(this.conn); |
There was a problem hiding this comment.
It's ok to solve the issue we met, but this may bring memory leak issue in cpp layer. We need figure out some way in later PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue:
Core dump will happen when trying to client disconnect which actually not successfully created.