Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure parse_url has the same semantics as Spark #142

Merged

Conversation

jackylee-ch
Copy link

Here are the changes in this pr.

  1. support parse fragment;
  2. change authority semantics;
  3. return null pointer while query or fragment is empty;

@github-actions
Copy link

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW

Opening JIRAs ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename pull request title in the following format?

ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

See also:

@PHILO-HE
Copy link

Some spark tests cases can pass with this patch. But it looks like there are still some spark UT failure.
It is recommended to port the test cases in StringFunctionsSuite.scala of gazelle/spark to gandiva UT to facilitate debugging. Thanks!

@jackylee-ch
Copy link
Author

Some spark tests cases can pass with this patch. But it looks like there are still some spark UT failure. It is recommended to port the test cases in StringFunctionsSuite.scala of gazelle/spark to gandiva UT to facilitate debugging. Thanks!

Thanks for your advise, I have changed this PR and passed the StringFunctionsSuite.scala in gazelle/spark.

@PHILO-HE
Copy link

Great! The patch looks good! The related scala UT passed. @zhouyuan, please have a further check.

@zhouyuan zhouyuan merged commit 4b4b16d into oap-project:arrow-4.0.0-oap Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants