make component muteable and add revisionName #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: 天元 <[email protected]>
wonderflow
requested review from
hongchaodeng,
resouer,
technosophos and
vturecek
as code owners
resouer
reviewed
May 13, 2020
resouer
reviewed
May 15, 2020
Co-authored-by: Lei Zhang (Harry) <[email protected]>
resouer
reviewed
May 15, 2020
Co-authored-by: Lei Zhang (Harry) <[email protected]>
|
After this is implemented, we could add a section about why OAM choose to embed workload CR in component instead of ref workload CR - revision is the main concern here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lots of discussion have been made and it seems we all agree with Approach 3.
Recently I'm going to implement this feature, let me create this PR to fix #350 .
This also related with #343.
Signed-off-by: 天元 [email protected]