Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ENG-867): add default version of the action, add new example #6

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

triwats
Copy link
Contributor

@triwats triwats commented Aug 19, 2024

Description

  • Add new default (latest) as the input
  • Add new example
  • Add reference to version example in the README

Issue(s)

[ENG-867]

How to test

  1. Pull in action somewhere, attempt to overwrite the version

Copy link

README.md Outdated Show resolved Hide resolved
@triwats
Copy link
Contributor Author

triwats commented Sep 2, 2024

We're unable to merge this because it would break the more complex Cloud Config project. Added more context in the ticket: https://www.notion.so/Ensure-version-of-Terraform-is-pinned-in-Cloud-Config-734b31588adc441e834aea623ad09254?pvs=8&n=github_linkback

@triwats triwats marked this pull request as draft September 2, 2024 11:08
inputs:
terraform_version:
description: "The version of Terraform to use"
default: "1.94"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've set this to the newest version as default - but pinned. This prevents version from changing around ONA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant