Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENG-966] Make base dir an input variable #13

Merged
merged 1 commit into from
Sep 25, 2024
Merged

[ENG-966] Make base dir an input variable #13

merged 1 commit into from
Sep 25, 2024

Conversation

tweakster
Copy link
Contributor

@tweakster tweakster commented Sep 24, 2024 •
edited
Loading

Description

  • Allow non default base dirs

Issue(s)

ENG-966

How to test

  1. Run in another repo with a different directory set e.g. https://github.com/oaknational/oak-terraform-modules/actions/runs/11013152792/job/30581146159 (it fails, as expected, but with lstat modules/: no such file or directory)
  2. Run again without the terraform_base_dir set and check that still works e.g. https://github.com/oaknational/Cloud-Config/actions/runs/11014013454/job/30583656010

Checklist

@notion-workspace Notion Workspace
Copy link

Add the Terraform CI to the modules repo

@tweakster tweakster requested a review from a team September 24, 2024 12:44
@tweakster tweakster mentioned this pull request Sep 24, 2024
Merged
1 task
@triwats
Copy link
Contributor

triwats commented Sep 24, 2024

LGTM

@tweakster tweakster merged commit 36347be into main Sep 25, 2024
2 checks passed
@tweakster tweakster deleted the feat/ENG-966-allow-modules branch September 25, 2024 08:12
@oak-machine-user
Copy link
Collaborator

🎉 This issue has been resolved in version 1.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@triwats triwats triwats approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tweakster @triwats @oak-machine-user