Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ENG-872): adding basic folder structure #1

Merged
merged 9 commits into from
Aug 8, 2024
Merged

feat(ENG-872): adding basic folder structure #1

merged 9 commits into from
Aug 8, 2024

Conversation

triwats
Copy link
Contributor

@triwats triwats commented Aug 6, 2024

  • Adding new basic template
  • Relates to ENG-872

Copy link

@triwats triwats requested a review from tweakster August 6, 2024 15:57
@triwats
Copy link
Contributor Author

triwats commented Aug 8, 2024

As per the discussion this morning - will refactor this to make it more specific to Terraform rather than a general purpose actions repo. Will also rename this.

README.md Outdated
# oak-actions
# oak-terraform-actions

The `actions` folder is designed to house reusable GitHub Actions, making it easy to manage and share automation across different repositories. Each subfolder within `actions` contains a specific action with all necessary files and documentation.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this sentence still make sense given the change of function?

If this is for multiple terraform checks then the actions\terraform\ folder should probably be a little less generic in name.

Otherwise I'm assuming this is just for the one Action so this sentence probably needs rewording.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reworded, resolving!

Copy link

… improving docs, removing versioning as this is done via setup
@triwats triwats merged commit 840fa00 into main Aug 8, 2024
2 checks passed
@triwats triwats deleted the ENG-872 branch August 8, 2024 15:02
triwats added a commit that referenced this pull request Aug 12, 2024
feat(ENG-872): adding basic folder structure
@oak-machine-user
Copy link
Collaborator

🎉 This issue has been resolved in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants