-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PUPIL-1136 Use versioned versions of icons #345
Conversation
✅ Deploy Preview for lively-meringue-8ebd43 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved - image dot-png has been removed and new images have been added. Checked icons list against live storybook all images are present (except the removal of dot-png)
Add your PR description below
PUPIL-1154
image-map
- Monika requested itv
and ends with.svg
(so basically it needs to be versioned and have svg extension)Svg
component in OWA to Cloudinary andimage-map
- because the next task will be to replace that component withOakIcon
so we need them in hereLink to the design doc
https://deploy-preview-345--lively-meringue-8ebd43.netlify.app/?path=/docs/components-atoms-oakicon--docs
A link to the component in the deployment preview
Testing instructions
Check that icon component renders correctly
ACs