Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PUPIL-1136 Use versioned versions of icons #345

Merged
merged 8 commits into from
Jan 2, 2025

Conversation

weronika-szalas
Copy link
Contributor

@weronika-szalas weronika-szalas commented Dec 18, 2024

Add your PR description below

PUPIL-1154

  • Updated icons optimised by design team (reduced sizes)
  • Added two new icons to the image-map - Monika requested it
  • Made sure we are using versioned urls for all icons
  • Added type to complain if the url of icons doesn't start with v and ends with .svg (so basically it needs to be versioned and have svg extension)
  • removed icons from public folder as we decided to stay with Cloudinary approach
  • uploaded icons used by Svg component in OWA to Cloudinary and image-map - because the next task will be to replace that component with OakIcon so we need them in here

Link to the design doc

https://deploy-preview-345--lively-meringue-8ebd43.netlify.app/?path=/docs/components-atoms-oakicon--docs

A link to the component in the deployment preview

Testing instructions

Check that icon component renders correctly

ACs

Copy link

Copy link

netlify bot commented Dec 18, 2024

Deploy Preview for lively-meringue-8ebd43 ready!

Name Link
🔨 Latest commit 182b11d
🔍 Latest deploy log https://app.netlify.com/sites/lively-meringue-8ebd43/deploys/6764236d29f2ea00083c084c
😎 Deploy Preview https://deploy-preview-345--lively-meringue-8ebd43.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@weronika-szalas weronika-szalas changed the title Feat/pupil 1136 use versioned icons PUPIL-1136 Use versioned versions of icons Dec 18, 2024
@weronika-szalas weronika-szalas marked this pull request as ready for review December 18, 2024 15:23
Copy link

@RBrownsett RBrownsett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved - image dot-png has been removed and new images have been added. Checked icons list against live storybook all images are present (except the removal of dot-png)

@weronika-szalas weronika-szalas merged commit cb65ded into main Jan 2, 2025
9 checks passed
@weronika-szalas weronika-szalas deleted the feat/PUPIL-1136-use-versioned-icons branch January 2, 2025 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants