Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: revert to using icons from cloudinary #344

Merged

Conversation

weronika-szalas
Copy link
Contributor

How to review this PR

Leave this text block for the reviewer

  • Check component hierarchy is followed correctly
  • Check the design Heuristics have been followed
  • Check naming conventions have been applied
  • Check for these gotchyas:
    • Missing exports for Oak components
    • Accidental export of Internal components
    • Snapshots of unexpected components have been modified
    • Circular dependencies
    • Code duplication (via not using base components)
    • Non-functional storybook for this or related components
    • Sensitve files changed eg. atoms, or style tokens
    • Relative imports
    • Default exports

Add your PR description below

Link to the design doc

A link to the component in the deployment preview

Testing instructions

ACs

Copy link

Copy link

netlify bot commented Dec 17, 2024

Deploy Preview for lively-meringue-8ebd43 ready!

Name Link
🔨 Latest commit 0cd874d
🔍 Latest deploy log https://app.netlify.com/sites/lively-meringue-8ebd43/deploys/67617555c6e54400082e45e3
😎 Deploy Preview https://deploy-preview-344--lively-meringue-8ebd43.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@weronika-szalas weronika-szalas marked this pull request as ready for review December 17, 2024 13:02
Copy link

@RBrownsett RBrownsett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved - revert has restored current implementation - checked against icons from previous live storybook

@weronika-szalas weronika-szalas merged commit 022bb14 into main Dec 17, 2024
9 checks passed
@weronika-szalas weronika-szalas deleted the feat/PUPIL-1136-revert-to-using-icons-from-cloudinary branch December 17, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants