Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CTC-98 Add shadow to OakMediaClipList accordion #335

Merged
merged 6 commits into from
Dec 5, 2024
Merged

CTC-98 Add shadow to OakMediaClipList accordion #335

merged 6 commits into from
Dec 5, 2024

Conversation

weronika-szalas
Copy link
Contributor

@weronika-szalas weronika-szalas commented Dec 3, 2024 •
edited
Loading

How to review this PR

Leave this text block for the reviewer

  • Check component hierarchy is followed correctly
  • Check the design Heuristics have been followed
  • Check naming conventions have been applied
  • Check for these gotchyas:
    • Missing exports for Oak components
    • Accidental export of Internal components
    • Snapshots of unexpected components have been modified
    • Circular dependencies
    • Code duplication (via not using base components)
    • Non-functional storybook for this or related components
    • Sensitve files changed eg. atoms, or style tokens
    • Relative imports
    • Default exports

Add your PR description below

Added shadow to OakMediaClipList component:

  • shadow shouldn't appear if there is no scroll
  • shadow should disappear when the list is scrolled to the end

Link to the design doc

https://www.figma.com/design/iTimVTBZ3XcszhRa9KtD7r/Cycle-2-requirements---Teachers?node-id=0-1&node-type=canvas&focus-id=11-14616&m=dev

A link to the component in the deployment preview

https://deploy-preview-335--lively-meringue-8ebd43.netlify.app/?path=/docs/components-organisms-teacher-oakmediacliplist--docs

Testing instructions

ACs

@notion-workspace Notion Workspace
Copy link

oak-components: add shadow to OakMediaClipList if the content is scrollable

@netlify Netlify
Copy link

netlify bot commented Dec 3, 2024 •
edited
Loading

✅ Deploy Preview for lively-meringue-8ebd43 ready!

Name Link
🔨 Latest commit 8133ee5
🔍 Latest deploy log https://app.netlify.com/sites/lively-meringue-8ebd43/deploys/6751879b74f55300085c6c73
😎 Deploy Preview https://deploy-preview-335--lively-meringue-8ebd43.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@weronika-szalas weronika-szalas changed the title feat: add shadow to OakMediaClipList accordion CTC-98 Add shadow to OakMediaClipList accordion Dec 3, 2024
@weronika-szalas weronika-szalas marked this pull request as ready for review December 3, 2024 15:46
@RBrownsett
Copy link

Tested, no issues. Will be checked again when merged into to OWA

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 5, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
80.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@weronika-szalas weronika-szalas merged commit d6053b4 into main Dec 5, 2024
9 checks passed
@weronika-szalas weronika-szalas deleted the feat/CTC-98-add-shadow-to-accordion branch December 5, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k-huggs k-huggs k-huggs approved these changes

@RBrownsett RBrownsett Awaiting requested review from RBrownsett

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@weronika-szalas @RBrownsett @k-huggs